GOATS-970: Develop new SourceProfileSerializer and SED serializers for handling source profile data. #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source profile data. - Implement tests for new source profile and SED serializers. - Refactor names and structure of GPP instrument serializers and registry for clarity. - Update existing tests to reflect changes in serializer names and structure.
There was a problem hiding this comment.
Pull Request Overview
This PR implements new source profile and SED serializers for handling source profile data in GPP requests, while refactoring existing serializer names for consistency and clarity.
- Developed SourceProfileSerializer and supporting SED serializer infrastructure with registry pattern
- Refactored all GPP serializer class names to remove "GPP" prefix for improved naming consistency
- Updated all test files and imports to reflect the new serializer naming structure
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/goats_tom/serializers/gpp/test_exposure_mode.py | Updated test imports and class usage for renamed ExposureModeSerializer |
| tests/goats_tom/serializers/gpp/test_elevation_range.py | Updated test imports and class usage for renamed ElevationRangeSerializer |
| tests/goats_tom/serializers/gpp/test_brightnesses.py | Updated test imports and class usage for renamed BrightnessesSerializer |
| tests/goats_tom/serializers/gpp/source_profile/test_source_profile.py | Added comprehensive tests for new SourceProfileSerializer functionality |
| tests/goats_tom/serializers/gpp/source_profile/seds/test_registry.py | Added tests for new SEDRegistry component |
| tests/goats_tom/serializers/gpp/source_profile/seds/test_black_body.py | Added tests for new BlackBodySerializer implementation |
| tests/goats_tom/serializers/gpp/instruments/test_registry.py | Updated test imports for renamed InstrumentRegistry |
| tests/goats_tom/serializers/gpp/instruments/test_gmos_south_long_slit.py | Updated test imports for renamed GMOSSouthLongSlitSerializer |
| tests/goats_tom/serializers/gpp/instruments/test_gmos_north_long_slit.py | Updated test imports for renamed GMOSNorthLongSlitSerializer |
| tests/goats_tom/api_views/gpp/test_toos.py | Updated test mocks and added tests for new source profile functionality |
| src/goats_tom/static/js/gpp/source_profile_editor.js | Updated JavaScript values and added debug logging for source profile handling |
| src/goats_tom/serializers/gpp/source_profile/source_profile.py | Added new SourceProfileSerializer implementation |
| src/goats_tom/serializers/gpp/source_profile/seds/registry.py | Added SEDRegistry for mapping SED types to serializers |
| src/goats_tom/serializers/gpp/source_profile/seds/black_body.py | Added BlackBodySerializer for black body temperature validation |
| src/goats_tom/serializers/gpp/source_profile/seds/init.py | Added module initialization for SED serializers |
| src/goats_tom/serializers/gpp/source_profile/init.py | Added module initialization for source profile components |
| src/goats_tom/serializers/gpp/instruments/registry.py | Renamed classes removing GPP prefix and updated type aliases |
| src/goats_tom/serializers/gpp/instruments/gmos_south_long_slit.py | Renamed class removing GPP prefix |
| src/goats_tom/serializers/gpp/instruments/gmos_north_long_slit.py | Renamed class removing GPP prefix |
| src/goats_tom/serializers/gpp/instruments/init.py | Updated exports for renamed classes |
| src/goats_tom/serializers/gpp/exposure_mode.py | Renamed class removing GPP prefix |
| src/goats_tom/serializers/gpp/elevation_range.py | Renamed class removing GPP prefix |
| src/goats_tom/serializers/gpp/brightnesses.py | Renamed class removing GPP prefix |
| src/goats_tom/serializers/gpp/init.py | Updated exports for renamed classes and added SourceProfileSerializer |
| src/goats_tom/serializers/init.py | Removed old GPP serializer exports |
| src/goats_tom/api_views/gpp/toos.py | Updated imports and added source profile formatting method |
| .pre-commit-config.yaml | Commented out check-docstring-first hook |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 77.94% 78.36% +0.42%
==========================================
Files 250 256 +6
Lines 8007 8164 +157
Branches 483 487 +4
==========================================
+ Hits 6241 6398 +157
Misses 1677 1677
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davner
added a commit
that referenced
this pull request
Oct 20, 2025
…r handling source profile data. (#460) - Implement tests for new source profile and SED serializers. - Refactor names and structure of GPP instrument serializers and registry for clarity. - Update existing tests to reflect changes in serializer names and structure.
davner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.